fix: Enable default link behaviors on nav bar and side nav links #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 162 162
Lines 5289 5289
Branches 592 592
=======================================
Hits 3835 3835
Misses 1322 1322
Partials 132 132 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
requested changes
Nov 9, 2023
frontend/src/app/general/nav-bar-menu/nav-bar-menu.component.html
Outdated
Show resolved
Hide resolved
romeonicholas
force-pushed
the
link-behavior-fix
branch
3 times, most recently
from
678a351 to
22640bf
Compare
romeonicholas
force-pushed
the
link-behavior-fix
branch
from
22640bf to
9cd086a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MoritzWeber0
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Moving routerLinks out of the containing divs and into the anchors for nav bar and side nav links makes them behave like normal links (middle click to open new tab, right click to open context menu, etc.)